Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move computation of is_python_issue to on_ticket.py #1904

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

sweep-nightly[bot]
Copy link
Contributor

@sweep-nightly sweep-nightly bot commented Sep 26, 2023

Description

This PR moves the computation of the is_python_issue boolean from the get_files_to_change method in sweep_bot.py to the on_ticket function in on_ticket.py. It also logs is_python_issue as an event to Posthog and passes it to the get_files_to_change method.

Summary of Changes

  • Removed the computation of is_python_issue from the get_files_to_change method in sweep_bot.py.
  • Added the computation of is_python_issue to the on_ticket function in on_ticket.py.
  • Logged is_python_issue as an event to Posthog in on_ticket.py.
  • Passed is_python_issue to the get_files_to_change method in sweep_bot.py.

Fixes #1747.


🎉 Latest improvements to Sweep:


💡 To get Sweep to edit this pull request, you can:

  • Leave a comment below to get Sweep to edit the entire PR
  • Leave a comment in the code will only modify the file
  • Edit the original issue to get Sweep to recreate the PR from scratch

@sweep-nightly sweep-nightly bot added the sweep Assigns Sweep to an issue or pull request. label Sep 26, 2023
@sweep-nightly sweep-nightly bot mentioned this pull request Sep 26, 2023
2 tasks
@vercel
Copy link

vercel bot commented Sep 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sweep-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2023 1:05am

@wwzeng1 wwzeng1 merged commit a6e9742 into main Sep 26, 2023
4 of 6 checks passed
@wwzeng1 wwzeng1 deleted the sweep/move-computation-of-is-python-issue_6 branch September 26, 2023 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sweep Assigns Sweep to an issue or pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sweep: Posthog logging
1 participant